Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL query merger may get confused with "sort" #300

Closed
kinow opened this issue Nov 5, 2019 · 0 comments · Fixed by #726
Closed

GraphQL query merger may get confused with "sort" #300

kinow opened this issue Nov 5, 2019 · 0 comments · Fixed by #726
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kinow
Copy link
Member

kinow commented Nov 5, 2019

Describe the bug

I had two components with similar queries, and it was up to the query merger to combine the queries. While staring at the component and looking for CSS issues, I spotted the cycle points out-of-order (bug found some time ago by @hjoliver, fixed in the GraphQL query with the help of @dwsutherland).

The original query in the Tree view had: taskProxies(sort: { keys: ["cyclePoint"] }) {, while the new component GScan was using a query that had simply taskProxies {. It resulted in the final version missing the sort attribute.

Not sure whether it should be smart to always augment the list of attributes, or warn the user on discrepancies.

Release version(s) and/or repository branch(es) affected?

master

Steps to reproduce the bug

Add a second view, register to the LiveWorkflowService and use a GraphQL attribute without the sort. Then navigate to the Tree component, or use the GScan when/if merged.

Expected behavior

Ordered cycle points as returned by the GraphQL query.

Screenshots

Additional context

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@kinow kinow added the bug Something isn't working label Nov 5, 2019
@kinow kinow added this to the 1.0 milestone Nov 5, 2019
@kinow kinow mentioned this issue May 13, 2020
6 tasks
@kinow kinow modified the milestones: 1.0, 0.6.0 Aug 12, 2021
@kinow kinow self-assigned this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant