Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkflowService doesn't work with nodesEdges, edges, or any other top level entry #209

Closed
kinow opened this issue Sep 1, 2019 · 1 comment · Fixed by #543
Closed

WorkflowService doesn't work with nodesEdges, edges, or any other top level entry #209

kinow opened this issue Sep 1, 2019 · 1 comment · Fixed by #543
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kinow
Copy link
Member

kinow commented Sep 1, 2019

The current implementation of the WorkflowService is tailored for a GraphQL such as

{
  data: {
    workflow: {...},
    nodesEdges: {...},
    tasks: {....}
  }
}

The Vuex store has the methods to store the data.workflow object. And the service discards any other top level entry such as nodesEdges, tasks, etc. Picking only workflow.

But while reviewing cylc/cylc-flow#3337 & cylc/cylc-uiserver#70, and experimenting with Cylc UI to confirm nothing was broken, I noticed that the WorkflowService never populated the Vuex store.

We can work around it with GraphQL aliases, but it only works until another query is registered that overrides it by requesting workflows {}.

Maybe the WorkflowService would have to be renamed to GraphQLService, or simply refactored to store the data in the Vuex store, without picking any of its attributes.

@kinow kinow added the bug Something isn't working label Sep 1, 2019
@dwsutherland
Copy link
Member

Both tasks and nodesEdges can be sub fields of workflows ... but this seems kinda restrictive (as each query will be binned into the workflows by force)... I would vote to use data

@kinow kinow added this to the 1.0 milestone Sep 14, 2019
@kinow kinow mentioned this issue May 22, 2020
6 tasks
@kinow kinow mentioned this issue Jun 23, 2021
9 tasks
@kinow kinow self-assigned this Jul 5, 2021
@kinow kinow modified the milestones: 1.0, 0.5.0 Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants