Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc clean leaves behind broken runN symlink #4323

Closed
MetRonnie opened this issue Jul 23, 2021 · 4 comments · Fixed by #4362
Closed

cylc clean leaves behind broken runN symlink #4323

MetRonnie opened this issue Jul 23, 2021 · 4 comments · Fixed by #4362
Assignees
@wxtim
Labels
bug Something is wrong :(
Milestone
cylc-8.0b3

Comments

@MetRonnie
Copy link
Member

Say you have

~/cylc-run/myflow
|-- run1
|-- run2
`-- runN -> run2

cylc clean myflow/run2 doesn't currently change the target of runN to run1, instead it will leave it broken.

Pull requests welcome!
@MetRonnie MetRonnie added the bug Something is wrong :( label Jul 23, 2021
@MetRonnie MetRonnie added this to the cylc-8.0b3 milestone Jul 23, 2021
@wxtim wxtim self-assigned this Aug 16, 2021
@wxtim
Copy link
Member

wxtim commented Aug 17, 2021

After a discussion with @dpmatthews today I've been convinced that the correct behavior is to unlink the Symlink. It is not clear how Clean should pick an alternative dir to link to, so don't.

@wxtim wxtim mentioned this issue Aug 17, 2021
Merged
6 tasks
@MetRonnie
Copy link
Member Author

What reason is there not to choose the next-highest run number?

@dpmatthews
Copy link
Contributor

The runN link is designed to make it easy to access the latest run (e.g. paths to data files). If you delete the latest run does that mean that you're happy for runN to point to an older run? Maybe in some cases but not others? I think removing the link is the safer option.

@MetRonnie MetRonnie mentioned this issue Aug 19, 2021
Closed
@MetRonnie
Copy link
Member Author

Opened a question issue for it: #4369

@MetRonnie MetRonnie changed the title cylc clean needs to update runN symlink cylc clean leaves behind broken runN symlink Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wxtim wxtim

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.0b3
Development

Successfully merging a pull request may close this issue.

remove runN if symlink target is gone wxtim/cylc
3 participants
@dpmatthews @wxtim @MetRonnie