Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symlink dirs: move into [install] section #4219

Closed
oliver-sanders opened this issue May 18, 2021 · 3 comments · Fixed by #4250
Closed

symlink dirs: move into [install] section #4219

oliver-sanders opened this issue May 18, 2021 · 3 comments · Fixed by #4250
Labels
config change Involves a change to global or workflow config question Flag this as a question for the next Cylc project meeting. small
Milestone

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented May 18, 2021

The [symlink dirs] section applies only to the cylc install command, propose moving it into the [install] section.

For reference the config tree currently looks like so:

>>> from cylc.flow.cfgspec.globalcfg import SPEC
>>> print(SPEC.tree())
global.cylc
    ...
    [install]
        source dirs
    ...
    [symlink dirs]
        [<install target>]
            run
            log
            share
            share/cycle
            work

Pull requests welcome!

@oliver-sanders oliver-sanders added the question Flag this as a question for the next Cylc project meeting. label May 18, 2021
@oliver-sanders oliver-sanders added this to the cylc-8.0.0 milestone May 18, 2021
@oliver-sanders oliver-sanders added config change Involves a change to global or workflow config small labels May 18, 2021
@MetRonnie
Copy link
Member

So it would be [install][symlink dirs][<install target>]...? Can't see any reason not to

@dpmatthews
Copy link
Contributor

The [symlink dirs] section applies only to the cylc install command

Also used by cylc play (as part of remote init)

@datamel
Copy link
Contributor

datamel commented May 18, 2021

In my mind, I think it makes sense to move [symlink dirs] into the install section, even though it is used by cylc play. I can see see the install section as a setup type section, that deals with installation of files for a workflow. Rather than being only strictly used for cylc install?

@datamel datamel mentioned this issue Jun 8, 2021
7 tasks
@MetRonnie MetRonnie modified the milestones: cylc-8.0.0, cylc-8.0b2 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Involves a change to global or workflow config question Flag this as a question for the next Cylc project meeting. small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants