Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the runner controller to manage Runner by labels #1428

Closed
4 tasks
binoue opened this issue Feb 24, 2021 · 1 comment
Closed
4 tasks

Fix the runner controller to manage Runner by labels #1428

binoue opened this issue Feb 24, 2021 · 1 comment
Assignees
@tapih @binoue

Comments

@binoue
Copy link
Contributor

binoue commented Feb 24, 2021 •
edited
Loading

What

Currently, the runner controller does not manage Runner by labels.
Therefore, autoscale does not work well when extending a Runner that has failed CI.

How

See the issue below.
actions/actions-runner-controller#330

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@binoue binoue changed the title Fix runner controller to manage Runner by labels Fix the runner controller to manage Runner by labels Feb 24, 2021
@binoue binoue added the wait-for-external-factors Wait for factors that are external to Neco label Feb 26, 2021
@binoue binoue removed the wait-for-external-factors Wait for factors that are external to Neco label Mar 5, 2021
@binoue
Copy link
Contributor Author

binoue commented Mar 8, 2021

Close this as our upstream PR was merged
actions/actions-runner-controller#355

@binoue binoue closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tapih tapih

@binoue binoue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tapih @binoue