New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualenv helper doesn't deactivate properly on leave #67

Open

von opened this issue Feb 5, 2022 · 1 comment

von commented Feb 5, 2022

The virtualenv helper doesn't evaluate the output of run_deactivate_if_present() when leaving (src)

               eval run_deactivate_if_present
               smartcd on-leave run_deactivate_if_present

This results in smartcd just printing the shell code instead of deactivating the virtualenv:

❯ cd
[ "`type -w deactivate`" = "function" ] && deactivate

The text was updated successfully, but these errors were encountered:

Author

von commented Feb 5, 2022

I also suspect the test for deactivate being defined is broken under zsh. Here is what I see with type -w:

❯ type -w deactivate
deactivate: function
❯ echo $ZSH_VERSION
5.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment