From c5391d4d1b9e9d85f363d2b6519af32a59b756f6 Mon Sep 17 00:00:00 2001 From: cutebomb Date: Sat, 5 Aug 2023 13:36:32 +0800 Subject: [PATCH] fix bugs roll_skew and roll_kurt in aggregations.pyx --- pandas/_libs/window/aggregations.pyx | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/pandas/_libs/window/aggregations.pyx b/pandas/_libs/window/aggregations.pyx index b0dac23c3b8e2..4a1ac666c1475 100644 --- a/pandas/_libs/window/aggregations.pyx +++ b/pandas/_libs/window/aggregations.pyx @@ -607,22 +607,9 @@ def roll_skew(ndarray[float64_t] values, ndarray[int64_t] start, start, end ) output = np.empty(N, dtype=np.float64) - min_val = np.nanmin(values) values_copy = np.copy(values) with nogil: - for i in range(0, V): - val = values_copy[i] - if val == val: - nobs_mean += 1 - sum_val += val - mean_val = sum_val / nobs_mean - # Other cases would lead to imprecision for smallest values - if min_val - mean_val > -1e5: - mean_val = round(mean_val) - for i in range(0, V): - values_copy[i] = values_copy[i] - mean_val - for i in range(0, N): s = start[i] @@ -822,21 +809,8 @@ def roll_kurt(ndarray[float64_t] values, ndarray[int64_t] start, ) output = np.empty(N, dtype=np.float64) values_copy = np.copy(values) - min_val = np.nanmin(values) with nogil: - for i in range(0, V): - val = values_copy[i] - if val == val: - nobs_mean += 1 - sum_val += val - mean_val = sum_val / nobs_mean - # Other cases would lead to imprecision for smallest values - if min_val - mean_val > -1e4: - mean_val = round(mean_val) - for i in range(0, V): - values_copy[i] = values_copy[i] - mean_val - for i in range(0, N): s = start[i]