fix: typescript definition for optional data attributes #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisAnzieu
changed the title
levibostian
changed the title
levibostian
requested review from
ami-aman and
xtreem88
and removed request for
ami-aman
|
@AlexisAnzieu Thanks for opening the PR and contributing to
|
|
Thank you very much for contributing to the project, @AlexisAnzieu! This change is fantastic. Wanted to give you an update that we are performing internal testing of this change before we merge it in and ship it. Again, thanks for making this project better. |
levibostian
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
### [2.3.1](2.3.0...2.3.1) (2023-04-20) ### Bug Fixes * typescript definition for optional data attributes ([#51](#51)) ([4cec62a](4cec62a))
|
Thank you again, @AlexisAnzieu! Greatly appreciate your PR ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing is failing because of bad function parameters