-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: android opened metrics when app in background #156
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
android/src/main/java/io/customer/reactnative/sdk/messagingpush/RNCIOPushMessaging.kt
Show resolved
Hide resolved
android/src/main/java/io/customer/reactnative/sdk/messagingpush/RNCIOPushMessaging.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the solution. Looks good
### [2.5.1](2.5.0...2.5.1) (2023-07-03) ### Bug Fixes * android opened metrics when app in background ([#156](#156)) ([fb14cce](fb14cce))
closes: https://github.com/customerio/issues/issues/10211
blocked by release of: customerio/customerio-android#227
Changes
RNCIOPushMessaging
opened
event inonNewIntent
for simple push usingPushTrackingUtil
when app is in background