-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tracking push metrics from js #152
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor queries, rest looks good to me 👍🏻
## [3.1.0](3.0.0...3.1.0) (2023-07-05) ### Features * tracking push metrics from js ([#152](#152)) ([6f51703](6f51703))
hey @ami-aman, wanted to get some clarification from these changes. I've tried several approaches, different libraries, but after going through multiple configurations, I think this is the best workflow. Our team is migration from expo-notifications to customerio-react-native, but noticing significant gaps, namely event listeners for foreground and background. After investigating, I found this change, and it's exactly the setup we're looking for. Keeping the existing expo-notification listeners and just tracking push events using JS. But, when I send a push notification through customer.io expo-notification never picks it up. Was hoping to see your test repo, but getting a 404. Any pointers would be super helpful! |
Hey there, @miguelespinoza. The latest version of the React Native SDK comes with improved push metrics tracking as well as compatibility with In |
you read my mind! I just saw this a couple of mins ago: https://github.com/customerio/customerio-reactnative/pull/236/files |
hi @levibostian, I probably should have stated that I'm using Expo. considering the steps you share reference updates to |
You will need to perform a If you could, open a new issue or send a customer support request to Thanks! |
good point, if I encounter any issues I'll open a new PR. Had to switch priorities for today, but once I wrap those up, I'll follow up with the One last question, with |
No, you should not need to upgrade to v50. I would go ahead and try beta.15 on whatever version of Expo you're using today and if you encounter issues, open an issue. |
Description
closes : https://github.com/customerio/issues/issues/10195
This PR fixes the problem of compatibility issues between expo-notifications and customerio-expo-plugin additionally supporting react native customers using other libraries that might be interfering in the functionality of CIO-RN package.
This feature can be tested using
aman/expo-notifications
branch of customerio-expo-ami-app.Use case: