Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change in way to update config in ios #15

Merged
merged 6 commits into from
Jul 25, 2022
Merged

fix: change in way to update config in ios #15

merged 6 commits into from
Jul 25, 2022

Conversation

ami-aman
Copy link
Collaborator

closes https://github.com/customerio/issues/issues/7791

Android SDK allows setting up config only during initialisation, but iOS SDK allows config setup later on too. To maintain consistency on both the platforms, react native package now allows setting up config on initialisation which is same for both the platforms.

@ami-aman ami-aman requested a review from mrehan27 July 25, 2022 13:39
@ami-oss-ci
Copy link

ami-oss-ci commented Jul 25, 2022 •
edited
Loading

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@ami-aman ami-aman requested a review from xtreem88 July 25, 2022 13:39
@ami-aman ami-aman mentioned this pull request Jul 25, 2022
Merged
levibostian
levibostian approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next deployment of the iOS SDK adds a config handler in the SDK initializer. So, maybe you can use that in the future?

@ami-aman
Copy link
Collaborator Author

in the SDK initializer

This is exactly I am doing in this PR but in a different way. Once the iOS deployment is done, I would prefer changing this on the react native end as well.

@ami-aman ami-aman merged commit 8680b28 into develop Jul 25, 2022
@ami-aman ami-aman deleted the aman/ios-config-fix-to-match-android branch July 25, 2022 16:42
ami-ci pushed a commit that referenced this pull request Jul 25, 2022
@semantic-release-bot
chore: prepare for 1.0.0-alpha.3
35b872e 
## [1.0.0-alpha.3](1.0.0-alpha.2...1.0.0-alpha.3) (2022-07-25)

### Features

* android updates in package ([#13](#13)) ([b708fce](b708fce))

### Bug Fixes

* change in way to update config in ios ([#15](#15)) ([8680b28](8680b28))
@ami-ci
Copy link
Contributor

ami-ci commented Jul 25, 2022

🎉 This PR is included in version 1.0.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ami-ci pushed a commit that referenced this pull request Sep 15, 2022
@semantic-release-bot
chore: prepare for 1.0.0-beta.1
68bb113 
## 1.0.0-beta.1 (2022-09-15)

### Features

* android updates in package ([#13](#13)) ([b708fce](b708fce))
* android: package updates ([e87c6eb](e87c6eb))
* android: setup config with initialization ([e915343](e915343))
* creating customerio react native package ([#1](#1)) ([2d2bdae](2d2bdae))
* device attributes and other configurable properties ([#4](#4)) ([bd79d96](bd79d96))
* identify and clear user identity ([#2](#2)) ([4430b66](4430b66))
* in-app functionality in react native package ([488c0c0](488c0c0))
* update package version ([8526a69](8526a69))
* updated to android sdk 3.0.0-alpha.2 ([91978d7](91978d7))
* updating ios sdk version in podspec ([1b1c26f](1b1c26f))
* user-agent updates in package ([efff4fc](efff4fc))

### Bug Fixes

* change in way to update config in ios ([#15](#15)) ([8680b28](8680b28))
* initialized sdk from storage using context ([e3e609a](e3e609a))
* push notifications integration ([#10](#10)) ([5d7752d](5d7752d))

### Reverts

* update package version ([e02e6e5](e02e6e5))
@ami-ci
Copy link
Contributor

ami-ci commented Sep 15, 2022

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ami-ci pushed a commit that referenced this pull request Oct 24, 2022
@semantic-release-bot
chore: prepare for 1.0.0
f5c9825 
## 1.0.0 (2022-10-24)

### Features

* android updates in package ([#13](#13)) ([b708fce](b708fce))
* android: package updates ([e87c6eb](e87c6eb))
* android: setup config with initialization ([e915343](e915343))
* creating customerio react native package ([#1](#1)) ([2d2bdae](2d2bdae))
* device attributes and other configurable properties ([#4](#4)) ([bd79d96](bd79d96))
* identify and clear user identity ([#2](#2)) ([4430b66](4430b66))
* in-app functionality in react native package ([488c0c0](488c0c0))
* update package version ([8526a69](8526a69))
* updated to android sdk 3.0.0-alpha.2 ([91978d7](91978d7))
* updating ios sdk version in podspec ([1b1c26f](1b1c26f))
* user-agent updates in package ([efff4fc](efff4fc))

### Bug Fixes

* added support for android sdk 3.1.0 ([44a1b91](44a1b91))
* change in way to update config in ios ([#15](#15)) ([8680b28](8680b28))
* initialized sdk from storage using context ([e3e609a](e3e609a))
* push notifications integration ([#10](#10)) ([5d7752d](5d7752d))
* updating gist dependency version ([9f8ac3f](9f8ac3f))

### Reverts

* update package version ([e02e6e5](e02e6e5))
@ami-ci
Copy link
Contributor

ami-ci commented Oct 24, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levibostian levibostian levibostian approved these changes

@mrehan27 mrehan27 Awaiting requested review from mrehan27

@xtreem88 xtreem88 Awaiting requested review from xtreem88

Assignees
No one assigned
Labels
released on @alpha released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ami-aman @ami-oss-ci @ami-ci @levibostian