-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: push opened metrics tracked on Android 12 #119
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
Removed all reviewers since the PR states not to merge it. Next time, would creating a draft PR work for you? Instead of creating an open PR and ask not to merge it? I am OK with this, but think that draft PRs would be simpler. |
@levibostian Draft PRs are for incomplete changes. This PR is complete. The not merging caution was there because it is dependent on Android SDK changes and will not compile without native changes being available. The reviewers were added as the ticket is in testing and I wanted it to be reviewed with native PR, we cannot address PR comments after the testing is complete and native SDK is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, no changes are needed apart from changing the snapshot to stable. Once we make the changes, we can approve it.
// If SDK is already initialized from CIO service using context, initialize the local | ||
// reference with SDK instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment explains what the code is doing, but it doesn't explain why we are initializing the local SDK reference. What problem this code solves.
A suggestion is that the comment could be modified to answer the question:
Why do we have this code instead of modifying the class from:
private lateinit var customerIO: CustomerIO
to:
private val customerIO = CustomerIO.instance()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments to explain it more.
@Shahroz16 Updated SDK version to stable release |
### [2.3.2](2.3.1...2.3.2) (2023-04-20) ### Bug Fixes * push opened metrics tracked on Android 12 ([#119](#119)) ([dfd6fbd](dfd6fbd))
fixes: https://github.com/customerio/issues/issues/9483
android sdk changes: customerio/customerio-android#184
Changes