-
Notifications
You must be signed in to change notification settings - Fork 0
Deprecate hexo-nofollow #7
Comments
In fact I have deprecated hexo-filter-nofollow and ask users to use hexo-nofollow.. |
$ npm owner add curben hexo-filter-nofollow
+ curben (hexo-filter-nofollow)
$ npm deprecate hexo-filter-nofollow "" Done. |
I'll create PRs to https://github.com/SukkaW/hexo-filter-nofollow. |
This is a bit tricky due to github limitation on forking a fork. Edit: created a new branch in my repo as a fork of your repo. |
I am thinking to create a new Update I have added the proposal to hexo core team discussion. |
In the meantime, let's update your repo. |
I think it is a good idea to create a new repo |
hexo-nofollow already falls behind hexo-filter-nofollow. I prefer not to duplicate the commits of current PRs of hexo-filter-nofollow. Do you still intend to keep the repo under yourself? Otherwise, why not just migrate (transfer ownership) it to hexo. |
After migrate the current |
So, you're not proceeding with https://github.com/orgs/hexojs/teams/core/discussions/9? I'm holding off deprecation for now, until your rewrite. Depending how drastic is the change, I may or may not deprecate this plugin. |
@SukkaW
The recent fix is created by you. Since you also have the same plugin, I'm considering to deprecate this plugin in favor of yours.
The only difference between #6 and hexojs/hexo#3685 is that I removed the following line:
because I prefer to have
rel=noopener...
regardless of existence oftarget
.If you can provide an option to disable that line, e.g.
then that would be nice.
config.nofollow.ignoreTarget
can be disabled by default.The text was updated successfully, but these errors were encountered: