Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Deprecate hexo-nofollow #7

Closed
curbengh opened this issue Aug 23, 2019 · 10 comments · Fixed by #8
Closed

Deprecate hexo-nofollow #7

curbengh opened this issue Aug 23, 2019 · 10 comments · Fixed by #8

Comments

@curbengh
Copy link
Owner

@SukkaW
The recent fix is created by you. Since you also have the same plugin, I'm considering to deprecate this plugin in favor of yours.

The only difference between #6 and hexojs/hexo#3685 is that I removed the following line:

if (/target=/gi.test(str)) return str;

because I prefer to have rel=noopener... regardless of existence of target.
If you can provide an option to disable that line, e.g.

if (/target=/gi.test(str) && !config.nofollow.ignoreTarget) return str;

then that would be nice. config.nofollow.ignoreTarget can be disabled by default.

@SukkaW
Copy link

SukkaW commented Aug 23, 2019

In fact I have deprecated hexo-filter-nofollow and ask users to use hexo-nofollow..
Maybe I can add you to the package owner.

@SukkaW
Copy link

SukkaW commented Aug 23, 2019

$ npm owner add curben hexo-filter-nofollow
+ curben (hexo-filter-nofollow)
$ npm deprecate hexo-filter-nofollow ""  

Done.

@curbengh
Copy link
Owner Author

I'll create PRs to https://github.com/SukkaW/hexo-filter-nofollow.
In the meantime, can you enable "Issues" in your repo?

@curbengh
Copy link
Owner Author

curbengh commented Aug 23, 2019

This is a bit tricky due to github limitation on forking a fork.

Edit: created a new branch in my repo as a fork of your repo.

@SukkaW
Copy link

SukkaW commented Aug 23, 2019

I am thinking to create a new hexo-filter-nofollow repo under hexo organization.

Update

I have added the proposal to hexo core team discussion.

@curbengh
Copy link
Owner Author

In the meantime, let's update your repo.
SukkaW#1

@SukkaW
Copy link

SukkaW commented Aug 25, 2019

I think it is a good idea to create a new repo hexo-filter-nofollow under hexo organization, and then push hexo-nofollow into that repo.

@curbengh
Copy link
Owner Author

hexo-nofollow already falls behind hexo-filter-nofollow. I prefer not to duplicate the commits of current PRs of hexo-filter-nofollow.

Do you still intend to keep the repo under yourself? Otherwise, why not just migrate (transfer ownership) it to hexo.

@SukkaW
Copy link

SukkaW commented Aug 25, 2019

After migrate the current hexo-filter-nofollow repo into hexo organization still have the problem of fork a forked repo.
Also, I want to rewrite this plugin completely.

@curbengh
Copy link
Owner Author

So, you're not proceeding with https://github.com/orgs/hexojs/teams/core/discussions/9?

I'm holding off deprecation for now, until your rewrite. Depending how drastic is the change, I may or may not deprecate this plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants