Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Paths #11

Open
ambsw-technology opened this issue May 3, 2019 · 3 comments
Open

Support Multiple Paths #11

ambsw-technology opened this issue May 3, 2019 · 3 comments

Comments

@ambsw-technology
Copy link

I've reviewed a ton of packages that fulfill the same general purpose and am leaning towards this one. We use ssm-diff (with a bunch of PR'd improvements) to populate/administer parameter store using YAML files so nesting is natural for us. I really like how this package exposes those nested keys to the app. I also find the general approach sound.

The one thing that's attractive in other packages and not found in this one is the option to use multiple paths (e.g. separated by ; or :). This option makes it easier to import both server-specific configurations and common configurations (e.g. database). In other packages that support multiple paths, it's understood that keys in later paths may overwrite keys in earlier paths (both a practical requirement and a feature).

I see the advantages of path-as-environment-variable, but it also means that you can't workaround the one-path limitation by, for example, wrapping the app with two calls to the package (each with different paths).

@ambsw-technology
Copy link
Author

Just noticed (in the network) that @Marvelution has a patch for this. PR?

@markrekveld
Copy link

Sure I can open a PR for this: #13

@jamestelfer
Copy link
Member

@ambsw-technology the original PR was closed as it was stale, and didn't include any tests.

Are you still using this tool? Would this still be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants