Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: close package values on import? #3772

Open
myitcv opened this issue Feb 19, 2025 · 0 comments
Open

packages: close package values on import? #3772

myitcv opened this issue Feb 19, 2025 · 0 comments

Comments

@myitcv
Copy link
Member

myitcv commented Feb 19, 2025

The package value that results from an import is currently not closed. #629 (comment) and related discussions make the point that such an imported value cannot be made more complete/specific/etc by the importer, save for any approach like cue.mod/usr or aspect oriented package-level augmentations in the main module. But even with such augmentations, it's arguably impossible for the importer to do anything further at the point of importing. As such, closing such a package value helps to shift left errors where references to non-existent fields are caught early.

Capturing this as a separate issue, so that we don't have to point people to a comment buried within an ancient issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant