Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/mod: TestWorkParallel flake on windows with Go 1.20 #2683

Closed
mvdan opened this issue Nov 9, 2023 · 0 comments
Closed

internal/mod: TestWorkParallel flake on windows with Go 1.20 #2683

mvdan opened this issue Nov 9, 2023 · 0 comments
Labels

Comments

@mvdan
Copy link
Member

mvdan commented Nov 9, 2023

https://github.com/cue-lang/cue/actions/runs/6814173381/job/18530431005

$ go test ./...
[...]
--- FAIL: TestWorkParallel (1.02s)
    work_test.go:53: par.Work.Do does not seem to be parallel
FAIL
FAIL	cuelang.org/go/internal/mod/mvs/internal/par	1.647s

This just made CI on master fail; it seems to be a sort of flake, since on windows with Go 1.21 with the same commit it passed, as well as both windows workflows on other nearby commits.

If this keeps happening, we should skip or disable the test. Interestingly enough, the test is exactly the same in upstream Go, but they don't seem to be running into flakes.

cc @rogpeppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant