internal/core/export: fix a few staticcheck warnings

Remove some unused code; it's always in the git history if needed.
While here, replace uses of the deprecated io/ioutil in tests.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: Ic7ec2a7937f99c093c27df469f84090592991ef5
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1169108
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Roger Peppe <[email protected]>

Author: mvdan

internal/core/export/export.go

@@ -284,8 +284,6 @@ type exporter struct {
 	letAlias   map[*ast.LetClause]*ast.LetClause
 	references map[*adt.Vertex]*referenceInfo
 
-	usedHidden map[string]bool
-
 	pivotter *pivotter
 }
 
@@ -786,19 +784,3 @@ func (e *exporter) setDocs(x adt.Node) {
 	f.docSources = []adt.Conjunct{adt.MakeRootConjunct(nil, x)}
 	e.stack[len(e.stack)-1] = f
 }
-
-// func (e *Exporter) promise(upCount int32, f completeFunc) {
-// 	e.todo = append(e.todo, f)
-// }
-
-func (e *exporter) errf(format string, args ...interface{}) *ast.BottomLit {
-	err := &exporterError{}
-	e.errs = errors.Append(e.errs, err)
-	return &ast.BottomLit{}
-}
-
-type errTODO errors.Error
-
-type exporterError struct {
-	errTODO
-}

internal/core/export/expr.go

@@ -353,7 +353,6 @@ func (c *conjuncts) addConjunct(f adt.Feature, t adt.ArcType, env *adt.Environme
 
 type field struct {
 	arcType   adt.ArcType
-	docs      []*ast.CommentGroup
 	arc       *adt.Vertex
 	conjuncts []conjunct
 }

internal/core/export/self.go

@@ -110,7 +110,6 @@ func (d *depData) usageCount() int {
 
 type refData struct {
 	dst *depData
-	ref ast.Expr
 }
 
 func (v *depData) node() *adt.Vertex {

internal/core/export/self_test.go

@@ -16,8 +16,6 @@ package export_test
 
 import (
 	"bytes"
-	"io/ioutil"
-	"log"
 	"strings"
 	"testing"
 
@@ -116,12 +114,7 @@ func patch(t *testing.T, r *cue.Context, orig *txtar.Archive, f *ast.File) cue.V
 		Data: b,
 	})
 
-	dir, err := ioutil.TempDir("", "test")
-	if err != nil {
-		log.Fatal(err)
-	}
-
-	instance := cuetxtar.Load(&a, dir)[0]
+	instance := cuetxtar.Load(&a, t.TempDir())[0]
 	if instance.Err != nil {
 		t.Fatal(instance.Err)
 	}
@@ -156,13 +149,8 @@ module: "mod.test/a"
 		t.Skip()
 	}
 
-	dir, err := ioutil.TempDir("", "test")
-	if err != nil {
-		log.Fatal(err)
-	}
-
 	a := txtar.Parse([]byte(in))
-	instance := cuetxtar.Load(a, dir)[0]
+	instance := cuetxtar.Load(a, t.TempDir())[0]
 	if instance.Err != nil {
 		t.Fatal(instance.Err)
 	}