-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build gherkin/dart #24
Comments
Oops. I figured the fact that the CI was failing before we added Dart to the build image meant it was being tested in CI. I should have looked closer. @lamkr are you interested in helping with this? It would be good to see how easy the CI / Make infrastructure is to understand for someone new to it. |
hi, @mattwynne ! I don't have that much time available but I will do my best to help. I'm not an expert in CI either, but where can I start? |
@lamkr I think the place to start is to add a @ciaranmcnulty it strikes me this could present a good opportunity to try our ideas about breaking up the Docker image monolith, since the Makefile here is essentially green field? |
I've realised that the |
Resolved by #3 |
The new gherkin/dart module is not built in CI.
When cucumber/common#1630 was merged we forgot to add a job to
.circleci/config.yml
, so it isn't built as a separate job. There is nothing ingherkin/Makefile
either, so the module isn't built as part of the serial job either./cc @mattwynne @aurelien-reeves
The text was updated successfully, but these errors were encountered: