-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gherkin testdata duplication #21
Comments
Yup. The subrepo sync would copy the language subtree. If the data wasn't duplicated, the sub repos build would fail. |
I do think that fixing this is tied up with extracting gherkin from the common repo. I believe that PHP still requires a subrepo so we may not be able to get rid of it so easily. On the otherhand, if we can make php work withouth a subrepo, we can do the deduplication. |
PHP doesn't need test data in the subrepo, I don't think |
There are no automated build within subrepos. And I am not sure any subrepo has already been used as a dev environment and thus needed to actually build I might submit a PR to remove that duplication in the monorepo. Any objection? |
Partially fixed with #3 |
Good enough for now. Dart is it's own problem. |
🤔 What's the problem you've observed?
Testdata for gherkin are duplicated into each implementation. In case of update of the testdata, it generates huge diffs which are making PRs difficult to review properly (cf. cucumber/common#1741)
✨ Do you have a proposal for making it better?
Stop duplicating testdata and refer to those using relative paths
Or at least duplicating the testdata during the build, but ignoring those from the repo
📚 Any additional context?
Why the purpose of the duplication? Is it because of the subrepos?
This text was originally generated from a template, then edited by hand. You can modify the template here.
The text was updated successfully, but these errors were encountered: