From 6603b82ceb4a3d192330c31676e4607e22ffa0ed Mon Sep 17 00:00:00 2001 From: "M.P. Korstanje" Date: Fri, 30 Dec 2022 16:43:56 +0100 Subject: [PATCH] Fix messages dependency versions (#83) Allow messages v19.1.4 to v20.0.1 to be used by Javascript, PHP and Ruby. With v19 [the messages protocol was expanded with keyword types][1]. Since then no relevant changes for Gherkin have been made. This means we can expand the range of allowed message versions somewhat. 1: https://github.com/cucumber/messages/blob/main/CHANGELOG.md#1900---2022-05-31 --- CHANGELOG.md | 1 + javascript/package.json | 2 +- php/composer.json | 2 +- ruby/cucumber-gherkin.gemspec | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3187a5842..f3c88af68 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org). This document is formatted according to the principles of [Keep A CHANGELOG](http://keepachangelog.com). ## [Unreleased] +- [Javascript, PHP, Ruby] Allow messages v19.1.4 to v20.0.1 to be used ## [26.0.2] - 2022-12-27 ### Fixed diff --git a/javascript/package.json b/javascript/package.json index 20cd6dda2..b6ac98a63 100644 --- a/javascript/package.json +++ b/javascript/package.json @@ -40,7 +40,7 @@ "typescript": "4.9.4" }, "dependencies": { - "@cucumber/messages": "^21.0.0" + "@cucumber/messages": "19.1.4 - 21" }, "directories": { "test": "test" diff --git a/php/composer.json b/php/composer.json index 08b15aa47..b85e7eeb0 100644 --- a/php/composer.json +++ b/php/composer.json @@ -15,7 +15,7 @@ "require": { "php": "^8.1", "ext-mbstring": "*", - "cucumber/messages": "^21.0" + "cucumber/messages": "19.1.4 - 21" }, "require-dev": { "phpunit/phpunit": "^9.5", diff --git a/ruby/cucumber-gherkin.gemspec b/ruby/cucumber-gherkin.gemspec index 6431ff0e8..41a2dba19 100644 --- a/ruby/cucumber-gherkin.gemspec +++ b/ruby/cucumber-gherkin.gemspec @@ -20,7 +20,7 @@ Gem::Specification.new do |s| 'source_code_uri' => 'https://github.com/cucumber/gherkin/blob/main/ruby' } - s.add_dependency 'cucumber-messages', '~> 19.1', '>= 19.1.4' + s.add_runtime_dependency 'cucumber-messages', '>= 19.1.4', '< 22.0' s.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6' s.add_development_dependency 'rspec', '~> 3.11', '>= 3.11.0'