Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false negative return for broken feature file #2225

Closed
triesztui opened this issue Jan 23, 2023 · 5 comments Β· Fixed by #2233
Closed

false negative return for broken feature file #2225

triesztui opened this issue Jan 23, 2023 · 5 comments Β· Fixed by #2233
Labels
πŸ› bug Defect / Bug βœ… accepted The core team has agreed that it is a good idea to fix this

Comments

@triesztui
Copy link

triesztui commented Jan 23, 2023

πŸ‘“ What did you see?

test executions returned 0 (left pipeline green) even though no test ran at all due to one broken feature file

βœ… What did you expect to see?

cucumber-js should return nonzero in case of feature file parsing errors

πŸ“¦ Which tool/library version are you using?

$ node -v
v19.4.0
$ npm -v
9.2.0
$ node_modules/@cucumber/cucumber/bin/cucumber-js -v
This Node.js version (v19.4.0) has not been tested with this version of Cucumber; it should work normally, but please raise an issue if you see anything unexpected.
8.10.0

πŸ”¬ How could we reproduce it?

Steps:

  1. put some >>>>> signs into a feature file

$ node_modules/@cucumber/cucumber/bin/cucumber-js
This Node.js version (v19.4.0) has not been tested with this version of Cucumber; it should work normally, but please raise an issue if you see anything unexpected.
Parse error in "features/xxxxxx.feature" (4:5): expected: #TagLine, #RuleLine, #Comment, #Empty, got '>>>>>>>> Scenario Outline: xxxxxxx'
...

$ echo $?
0

@davidjgoss davidjgoss added πŸ› bug Defect / Bug βœ… accepted The core team has agreed that it is a good idea to fix this labels Feb 10, 2023
@davidjgoss
Copy link
Contributor

Thanks for raising @triesztui. I can reproduce this too and will dig into it soon.

@davidjgoss
Copy link
Contributor

Are you using the html formatter @triesztui? Initial investigation suggests it's related.

@davidjgoss
Copy link
Contributor

@triesztui
Copy link
Author

yes I do use the html formatter. Thank you very much for looking into this David.

@triesztui
Copy link
Author

fix works well, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Defect / Bug βœ… accepted The core team has agreed that it is a good idea to fix this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants