Skip to content

Commit 896dd41

Browse files
onefloidMariusWirtz
authored andcommitted
Refactor: Simplify parameter validation
1 parent 20bfffd commit 896dd41

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

TM1py/Services/CubeService.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,7 @@ def update_or_create_rules(self, cube_name: str, rules: Union[str, Rules], **kwa
145145
"""
146146
if isinstance(rules, str):
147147
rules = Rules(rules=rules)
148-
if isinstance(rules, Rules):
149-
pass
150-
else:
148+
if not isinstance(rules, Rules):
151149
raise ValueError('rules must be type str or Rules')
152150

153151
url = format_url("/Cubes('{}')", cube_name)

0 commit comments

Comments
 (0)