get rid of mb2's .forget() invocations #800
Labels
bug
Something isn't working
easy
Trivial to do (even when tired!) and semi-worthwhile
high priority
Should be done fairly soon
Get rid of all the calls to
.forget()
that mb2's web client uses.I didn't think that calling
.forget
on aTimeout
leaks memory, but it does, at least until we can invokewasm-bindgen
with--weak-refs
. There's currently no way to tellweb-pack
to invokewasm-bindgen
that way though.I believe we're currently only calling
.forget()
for resize handlers (i.e. one per window, so that leakage doesn't really matter) andTimeout
s. It's theTimeout
s that could be an issue, but it's trivial to fix for the resize handlers, since there's an obvious place to store the closure. Each of theTimeout
s will require a bespoke solution.The text was updated successfully, but these errors were encountered: