New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

px unit is not appended to css rowGap property #1435

Closed

VineethK336 opened this issue Dec 26, 2020 · 1 comment

Contributor

VineethK336 commented Dec 26, 2020 •

edited

Loading

Expected behavior:
When we give the css rowGap: 10, jss should have ideally translated it to row-gap: 10px
css row-gap

Describe the bug:
However, it was translated to row-gap: 10 (The unit px is missing)

Codesandbox link:
Here's a simple reproduction of the issue: https://codesandbox.io/s/vigilant-pine-z4ytr?file=/src/App.js

Versions (please complete the following information):

jss: 10.5.0
Browser [e.g. chrome, safari]: Chrome 87
OS [e.g. Windows, macOS]: macOS 10.15.6

Came here following this issue: mui/material-ui#23505

If the fix is to add an entry for row-gap in packages/jss-plugin-default-unit/src/defaultUnits.js, I'd be happy to create a PR as well.

The text was updated successfully, but these errors were encountered:

VineethK336 mentioned this issue

feat: add px as default unit for row-gap property #1436

Merged

3 tasks

kof closed this as completed

Member

kof commented Jan 23, 2021

Released https://github.com/cssinjs/jss/releases/tag/v10.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment