Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with TypeScript. WithStyles type #1107

Closed
vtereshyn opened this issue May 16, 2019 · 5 comments
Closed

Usage with TypeScript. WithStyles type #1107

vtereshyn opened this issue May 16, 2019 · 5 comments

Comments

@vtereshyn
Copy link
Contributor

Recently, I created a new project with the latest versions each of dependencies. I did all step by step according to documentation . But got an error that WithStyles doesn't exist in react-jss.
Later, I found that WithStyles exists in alpha pre-release version only (v10.0.0-alpha.16). It's OK, but let's add this to documentation as well, since it can be confused for new jss users as me :)

Please, let me know if it works for you and I'll create a PR

@HenriBeck
Copy link
Member

Sounds great, the TS types are since version 10 (which is currently in alpha) in this repo just FYI.

So not only v10.0.0-alpha.16

@vtereshyn
Copy link
Contributor Author

Oh, found that documentation is already fixed in #1078, but hasn't released yet :)

@HenriBeck
Copy link
Member

Hmmm, that's weird because any docs changes should be live as soon as they are merged to master

@vtereshyn
Copy link
Contributor Author

Yes, so master is incompatible with current website and docs version

@HenriBeck
Copy link
Member

Oh wait, no, so docs are not automatically updated 🤦‍♂
They will be updated once we release a new version and create a new GitHub release.

I think we will release the next version in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants