Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String comparison causing test to fail on Appveyor #95

Closed
mdpiper opened this issue Oct 8, 2019 · 2 comments · Fixed by #93
Closed

String comparison causing test to fail on Appveyor #95

mdpiper opened this issue Oct 8, 2019 · 2 comments · Fixed by #93

Comments

@mdpiper
Copy link
Member

mdpiper commented Oct 8, 2019

The test_find_metadata test in test_setup.py is failing on Windows because os.path.abspath returns a lowercase drive letter, "c:" which fails when compared to uppercase "C:".
@mdpiper
Copy link
Member Author

mdpiper commented Oct 8, 2019

@mcflugen suggests fixing this with pathlib.

This was referenced Oct 8, 2019
Merged
Merged
@mdpiper
Copy link
Member Author

mdpiper commented Oct 9, 2019

Interestingly, the suspect test didn't fail in #96. Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compare lowercased strings csdms/pymt
1 participant
@mdpiper