Tian fix demo notebooks #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcflugen @gantian127 I diffed this branch against master and found nothing that would decrease the coverage. Given this + the known issue with Appveyor, I think this PR is fine to merge. At some point we should create additional tests to increase the coverage. (Perhaps you'd be interested in doing this, Tian, since it's Python, not C!) |
|
@mdpiper Thanks for checking my code. I would love to learn and work on adding additional tests to increase the coverage in the future. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue csdms/help-desk#10
subside, sedflux3D notebooks were rerun and tested
child and Sedflux3D_and_child notebooks were only updated with the code