Tiangan/update link for notebooks #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gantian127 Oh, this is unfortunate -- it looks like one of the doctests is failing, probably because of an update to an underlying library ( |
This allows Python 3.6.1 or greater to be installed, which fixes an
import error from the `typing` module:
ImportError: cannot import name 'AsyncGenerator'
which in turn fixes the failing docs build in pymt.
h/t https://github.com/pgjones/quart/issues/19#issuecomment-385890334
This change appears to be caused by a change to the underlying netCDF4.netcdftime.utime module. This caused the doctest to fail, but no unit tests failed.
|
I'm going to merge this PR despite the appveyor issue (which is addressed in#93). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the github links in the example notebooks.