Multiple @kwcalls redefines methods causing warnings

[mileslucas]

JuliaAstro/Transits.jl#23 (comment)

Calling @kwcall multiple times on the same method name will create warnings in module code. This is happening because

KeywordCalls.jl/src/KeywordCalls.jl

Lines 39 to 43 in 96b14dc

	q = quote
	KeywordCalls._call_in_default_order(::typeof($f), nt::NamedTuple{($(sorted_args...),)}) = $f(NamedTuple{($(args...),)}(nt))
	$f(nt::NamedTuple) = KeywordCalls._call_in_default_order($f, _sort(merge($defaults, $alias($f, nt))))
	$f(; kw...) = $f(merge($defaults, $alias($f, NamedTuple(kw))))
	end

adds the two foo(::NamedTuple) and foo(; kwargs...) calls, regardless if they exist already.

[mileslucas]

Could this be handled with hasmethod?

q = quote
    KeywordCalls._call_in_default_order(::typeof($f), nt::NamedTuple{($(sorted_args...),)}) = $f(NamedTuple{($(args...),)}(nt))
	if !hasmethod($f, Tuple{NamedTuple})
	    $f(nt::NamedTuple) = KeywordCalls._call_in_default_order($f, _sort(merge($defaults, $alias($f, nt))))
	end
	if !hasmethod($f, Tuple{})
	    $f(; kw...) = $f(merge($defaults, $alias($f, NamedTuple(kw))))
	end
end

[cscherrer]

Thanks for catching this! This seems like the right idea. Let's see if we can do this with the hasmethod checks outside the quote, roughly like

q = quote
    KeywordCalls._call_in_default_order(::typeof($f), nt::NamedTuple{($(sorted_args...),)}) = $f(NamedTuple{($(args...),)}(nt))
end

if !hasmethod(f, Tuple{NamedTuple})
    push!(q.args, :($f(nt::NamedTuple) = KeywordCalls._call_in_default_order($f, _sort(merge($defaults, $alias($f, nt)))))
end

if !hasmethod(f, Tuple{})
    push!(q.args, :($f(; kw...) = $f(merge($defaults, $alias($f, NamedTuple(kw)))))
end

If we need the hasmethod in the generated code, we can try static_hasmethod from Tricks.jl