From 215444a808a619db8216c9fdff95447dbf80f449 Mon Sep 17 00:00:00 2001 From: Julien Portalier Date: Tue, 6 Feb 2024 10:10:23 +0100 Subject: [PATCH] Fix: don't run thread specs with the interpreter Starting threads very likely requires support from the interpreter to create the thread (so it knows about it) to run the interpreted code in. This also fixes the "can't resume running fiber" exceptions that started appearing in the wait group pull request, because they were always run after the thread related specs. --- spec/interpreter_std_spec.cr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/interpreter_std_spec.cr b/spec/interpreter_std_spec.cr index 8638b0a83f7f..79b8bab3edbc 100644 --- a/spec/interpreter_std_spec.cr +++ b/spec/interpreter_std_spec.cr @@ -235,9 +235,9 @@ require "./std/system_error_spec.cr" require "./std/system/group_spec.cr" # require "./std/system_spec.cr" (failed to run) require "./std/system/user_spec.cr" -require "./std/thread/condition_variable_spec.cr" -require "./std/thread/mutex_spec.cr" -# require "./std/thread_spec.cr" (failed to run) +# require "./std/thread/condition_variable_spec.cr" (interpreter must support threads) +# require "./std/thread/mutex_spec.cr" (interpreter must support threads) +# require "./std/thread_spec.cr" (interpreter must support threads) require "./std/time/custom_formats_spec.cr" require "./std/time/format_spec.cr" require "./std/time/location_spec.cr"