Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem:CRC20 standard is not settled down and documented #62

Closed
yihuang opened this issue Sep 9, 2021 · 3 comments
Closed

Problem:CRC20 standard is not settled down and documented #62

yihuang opened this issue Sep 9, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation evm This issue or PR is related to EVM help wanted Extra attention is needed high priority

Comments

@yihuang
Copy link
Collaborator

yihuang commented Sep 9, 2021

Early stage proposal

native denom conversion

  • mint_by_cronos_module(address user, uint256 amount)
  • burn_by_cronos_module(address user, uint256 amount)
  • native_denom() returns (string)

bridge call

  • send_to_ibc(address recipient, uint256 amount)
  • send_to_ethereum(address recipient, uint256 amount)

native call events

  • __CronosSendToAccount(address recipient, uint256 amount)
  • __CronosSendToEthereum(address eth_recipient, uint256 amount, uint256 bridge_fee)
  • __CronosSendToIBCChannel(address recipient, uint256 amount)
@tomtau tomtau added documentation Improvements or additions to documentation evm This issue or PR is related to EVM help wanted Extra attention is needed high priority labels Oct 28, 2021
@landanhu
Copy link
Contributor

I think this issue can be closed now, given we've been using https://github.com/crypto-org-chain/cronos/blob/main/contracts/src/ModuleCRC20.sol?

Or we will only close after we add some proper documentation?
Should the documentation be an ADR in https://github.com/crypto-org-chain/cronos/tree/main/docs/architecture? If not, where else is best to place it? @yihuang @tomtau @calvinaco @thomas-nguy thanks ahead!

@thomas-nguy
Copy link
Collaborator

thomas-nguy commented Feb 25, 2022

I would say

  • Write ADR for the bridge solution ETH <-> Cronos which document the hook logic and ModuleCRC20 contract
  • For CRC20 standard or other CRCXX standard, lets open a new repository

For now CRC20 and ModuleCRC20 are almost the same, so we could just create an ADR

@yihuang
Copy link
Collaborator Author

yihuang commented Mar 9, 2022

Consider it fixed by the new repo: https://github.com/crypto-org-chain/cronos-public-contracts.

@yihuang yihuang closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation evm This issue or PR is related to EVM help wanted Extra attention is needed high priority
Projects
None yet
Development

No branches or pull requests

4 participants