Problem: memory is missing in keyring backend help comment #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Add `memory` option in help text. Fixes crypto-org-chain#334.
devashishdxt
requested review from
calvinaco,
leejw51crypto,
linfeng-crypto,
tomtau and
yihuang
as code owners
tomtau
approved these changes
Jan 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 12.12% 12.12%
=======================================
Files 32 32
Lines 5171 5171
=======================================
Hits 627 627
Misses 4295 4295
Partials 249 249
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yihuang
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Add
memoryoption in help text. Fixes #334.