From 32e7b9195b96fe65aed9792b054c298f0734c5e3 Mon Sep 17 00:00:00 2001 From: "zhengxing.li" Date: Tue, 23 Aug 2016 19:37:37 -0700 Subject: [PATCH] X87: TurboFan: Introduce TaggedSigned and TaggedPointer representations. port d941b52d7328f6d223a1dc1ffb134221500dbb00 (r38657) original commit message: These new representations aren't used yet. BUG= Review-Url: https://codereview.chromium.org/2277473004 Cr-Commit-Position: refs/heads/master@{#38849} --- src/compiler/x87/instruction-selector-x87.cc | 28 +++++++++++++------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/src/compiler/x87/instruction-selector-x87.cc b/src/compiler/x87/instruction-selector-x87.cc index 059550ca77b..397f9ac16bf 100644 --- a/src/compiler/x87/instruction-selector-x87.cc +++ b/src/compiler/x87/instruction-selector-x87.cc @@ -187,7 +187,9 @@ void InstructionSelector::VisitLoad(Node* node) { case MachineRepresentation::kWord16: opcode = load_rep.IsSigned() ? kX87Movsxwl : kX87Movzxwl; break; - case MachineRepresentation::kTagged: // Fall through. + case MachineRepresentation::kTaggedSigned: // Fall through. + case MachineRepresentation::kTaggedPointer: // Fall through. + case MachineRepresentation::kTagged: // Fall through. case MachineRepresentation::kWord32: opcode = kX87Movl; break; @@ -271,7 +273,9 @@ void InstructionSelector::VisitStore(Node* node) { case MachineRepresentation::kWord16: opcode = kX87Movw; break; - case MachineRepresentation::kTagged: // Fall through. + case MachineRepresentation::kTaggedSigned: // Fall through. + case MachineRepresentation::kTaggedPointer: // Fall through. + case MachineRepresentation::kTagged: // Fall through. case MachineRepresentation::kWord32: opcode = kX87Movl; break; @@ -333,10 +337,12 @@ void InstructionSelector::VisitCheckedLoad(Node* node) { case MachineRepresentation::kFloat64: opcode = kCheckedLoadFloat64; break; - case MachineRepresentation::kBit: // Fall through. - case MachineRepresentation::kTagged: // Fall through. - case MachineRepresentation::kWord64: // Fall through. - case MachineRepresentation::kSimd128: // Fall through. + case MachineRepresentation::kBit: // Fall through. + case MachineRepresentation::kTaggedSigned: // Fall through. + case MachineRepresentation::kTaggedPointer: // Fall through. + case MachineRepresentation::kTagged: // Fall through. + case MachineRepresentation::kWord64: // Fall through. + case MachineRepresentation::kSimd128: // Fall through. case MachineRepresentation::kNone: UNREACHABLE(); return; @@ -380,10 +386,12 @@ void InstructionSelector::VisitCheckedStore(Node* node) { case MachineRepresentation::kFloat64: opcode = kCheckedStoreFloat64; break; - case MachineRepresentation::kBit: // Fall through. - case MachineRepresentation::kTagged: // Fall through. - case MachineRepresentation::kWord64: // Fall through. - case MachineRepresentation::kSimd128: // Fall through. + case MachineRepresentation::kBit: // Fall through. + case MachineRepresentation::kTaggedSigned: // Fall through. + case MachineRepresentation::kTaggedPointer: // Fall through. + case MachineRepresentation::kTagged: // Fall through. + case MachineRepresentation::kWord64: // Fall through. + case MachineRepresentation::kSimd128: // Fall through. case MachineRepresentation::kNone: UNREACHABLE(); return;