Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityGroupRule docs missing ignoreIngress and ignoreEgress hint for using securityGroupId #1516

Closed
BGrasnick opened this issue Oct 6, 2022 · 0 comments · Fixed by #1517
Labels
bug Something isn't working

Comments

@BGrasnick
Copy link
Contributor

What happened?

When using SecurityGroup and SecurityGroupRule together and appending them directly using securityGroupId in the SecurityGroupRule we observed odd behavior of repeated recreation of SecurityGroupRules. By sheer luck I opened the collapsable on securityGroupIdRef and found out about ignoreIngress and ignoreEgress.

How can we reproduce it?

Create a SecurityGroup and use it's ID to create a SecurityGroupRule:

apiVersion: ec2.aws.crossplane.io/v1beta1
kind: SecurityGroup
metadata:
  name: my-sg
spec:
  forProvider:
    region: eu-central-1
    groupName: my-sg
    vpcId: my-vpc
    description: my description
apiVersion: ec2.aws.crossplane.io/v1alpha1
kind: SecurityGroupRule
metadata:
  name: my-sgr-1
spec:
  forProvider:
    protocol: "-1"
    fromPort: -1
    toPort: -1
    type: ingress
    region: eu-central-1
    securityGroupId: my-sg-id
    sourceSecurityGroupId: my-sg-id

When using the following SecurityGroup it does not happen:

apiVersion: ec2.aws.crossplane.io/v1beta1
kind: SecurityGroup
metadata:
  name: my-sg
spec:
  forProvider:
    region: eu-central-1
    groupName: my-sg
    vpcId: my-vpc
    description: my description
    ignoreEgress: true
    ignoreIngress: true

What environment did it happen in?

Crossplane version: 1.9.1
Kubernetes version (use kubectl version): v1.24.0
Kubernetes distribution (e.g. Tectonic, GKE, OpenShift): kind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant