aarch64-unknown-linux-musl build failed due to "CROSS_RUSTC_MINOR_VERSION: unbound variable" error #1046
Comments
Fixing the underlying problem (i.e., using an image known to be compatible with the current version by default) will avoid similar breakage in the future, but will not fix the problem occurring in the current release. In any case, it seems that if [[ -z "${CROSS_RUSTC_MINOR_VERSION:-}" ]]; then
CROSS_RUSTC_MINOR_VERSION=$(rustc -Vv | grep '^release:' | cut -d ':' -f2 | cut -d '.' -f2)
fi |
|
In summary, there's 2 issues here:
This was changed in #1028. There is, however, another issue if the released cross version isn't using a released tag, since we've made numerous backwards incompatible changes since then. This seems to be an issue specifically with using bininstall or installing cross from a pre-built binary. Normally, using @Emilgardis know how to fix the pre-built binaries? We should provide a fallback for the time being and also likely release |
|
I can provide a quick fallback (similar to what we did in #1028) but we also have a much larger issue here as well: that we've also been making backwards-incompatible changes to our images which are used by an incompatible version of cross installed from a pre-compiled binary. This also affects a few MIPS targets and an ARMv5TE target. |
|
The same error also happened in |
Yep this is an issue when cross is installed but not built from source from crates.io, IE, when not using
|
I think you mean
For |
|
This should be solvable by removing .git before compiling. the 0.2.4 changes can be done manually |
For |
|
I've created https://github.com/cross-rs/cross/tree/v0.2.4-fix from which we can grab the artifacts and replace canceled the run for now to let ci build #1047 |
|
The backwards incompability has been fixed now, remaining task now is to fix the |
|
I have updated the binaries on the release. https://github.com/cross-rs/cross/releases/tag/v0.2.4 This should now be resolved |
|
I've confirmed that it has been fixed in my use cases. Thanks for the swift fix! |
Checklist
Describe your issue
9311417 added
CROSS_RUSTC_MINOR_VERSIONenvironment variables without fallback, so the current docker image of themaintag is incompatible with the released version of cross (v0.2.4).log: https://github.com/taiki-e/cargo-llvm-cov/actions/runs/3170903254/jobs/5163844829
The underlying problem seems to be that
crossuses by defaultmaintag that may be incompatible with the current version. Using the tag that matches the version (0.2.4in this case) seems to work around the problem.What target(s) are you cross-compiling for?
aarch64-unknown-linux-musl
Which operating system is the host (e.g computer cross is on) running?
What architecture is the host?
What container engine is cross using?
cross version
cross 0.2.4 (4645d93 2022-07-10)
Example
Probably this can also be reproduced with a crate created with
cargo new --bininstead of cargo-llvm-cov.Additional information / notes
No response
The text was updated successfully, but these errors were encountered: