-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance accessibility by adding ARIA attributes to local content sections #890
Open
kris70lesgo
wants to merge
9
commits into
creativecommons:main
Choose a base branch
from
kris70lesgo:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kris70lesgo
requested review from
TimidRobot,
Shafiya-Heena and
dhruvkb
and removed request for
a team
January 13, 2025 14:19
@TimidRobot @Shafiya-Heena @possumbilities pls review |
1 task
TimidRobot
changed the title
"Enhance accessibility by adding ARIA attributes to local content sections"
Enhance accessibility by adding ARIA attributes to local content sections
Jan 13, 2025
TimidRobot
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the code comments, please try to remove unnecessary changes from this pull request (PR). The size of this PR makes it difficult to review and that is exacerbated by the additional formatting changes, etc.
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
themes/vocabulary_theme/templates/blocks/featured-projects.html
Outdated
Show resolved
Hide resolved
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
TimidRobot
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
Enhances accessibility by adding ARIA attributes to local content sections like forms, buttons, and navigation. This improves compatibility with assistive technologies such as screen readers.
Technical details
aria-label
,aria-describedby
, andaria-labelledby
were added to form elements, buttons, and other interactive components.Tests
Screenshots
Checklist
main
ormaster
).Developer Certificate of Origin
1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.