Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance accessibility by adding ARIA attributes to local content sections #890

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kris70lesgo
Copy link

@kris70lesgo kris70lesgo commented Jan 13, 2025

Fixes

Description

Enhances accessibility by adding ARIA attributes to local content sections like forms, buttons, and navigation. This improves compatibility with assistive technologies such as screen readers.

Technical details

  • ARIA attributes like aria-label, aria-describedby, and aria-labelledby were added to form elements, buttons, and other interactive components.
  • Ensured consistent accessibility between global and local content sections.

Tests

  1. Verify that all interactive elements have ARIA attributes.
  2. Test with screen readers to ensure accessibility improvements.
  3. Ensure the page functions normally without assistive technologies.

Screenshots

Checklist

  • My pull request has a descriptive title.
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made.
  • I added or updated documentation, if applicable.
  • I verified that the project runs locally without visible errors.

Developer Certificate of Origin

1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

@kris70lesgo kris70lesgo requested review from a team as code owners January 13, 2025 14:19
@kris70lesgo kris70lesgo requested review from TimidRobot, Shafiya-Heena and dhruvkb and removed request for a team January 13, 2025 14:19
@kris70lesgo
Copy link
Author

@TimidRobot @Shafiya-Heena @possumbilities pls review

@TimidRobot TimidRobot changed the title "Enhance accessibility by adding ARIA attributes to local content sections" Enhance accessibility by adding ARIA attributes to local content sections Jan 13, 2025
@TimidRobot TimidRobot self-assigned this Jan 13, 2025
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the code comments, please try to remove unnecessary changes from this pull request (PR). The size of this PR makes it difficult to review and that is exacerbated by the additional formatting changes, etc.

themes/vocabulary_theme/templates/blocks/get-involved.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/blocks/hero.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/blog-categories.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/blog-category.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/blog-series-list.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/layout.html Show resolved Hide resolved
themes/vocabulary_theme/templates/macros/og_image.html Outdated Show resolved Hide resolved
themes/vocabulary_theme/templates/page-with-title.html Outdated Show resolved Hide resolved
@possumbilities possumbilities removed request for a team and dhruvkb January 16, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Enhance Accessibility: Add ARIA Attributes to Local Content
3 participants