Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pullsecret #18

Closed
gbraad opened this issue Mar 21, 2023 · 0 comments · Fixed by #21
Closed

Handle pullsecret #18

gbraad opened this issue Mar 21, 2023 · 0 comments · Fixed by #21
Assignees

Comments

@gbraad
Copy link
Contributor

gbraad commented Mar 21, 2023

The extension need to properly request the pullsecret when needed and perform basic validation before setting it.

On startup, when no pull-secret is available, the start will be postponed until the user has provided this; a dialog or input will be shown to collect this.

The user should be abel to provide the pull-secret from the configuration before start.

Basic validation is performed to make sure the pull-secret is a valid json message; a simple { and } is sufficient as a first increment.

@evidolob evidolob self-assigned this Mar 21, 2023
@gbraad gbraad moved this to In Progress in Project planning: crc Mar 21, 2023
@gbraad gbraad linked a pull request Mar 21, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Project planning: crc Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants