Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless call in extension activation #158

Closed
jeffmaury opened this issue Jun 20, 2023 · 5 comments · Fixed by #169
Closed

Useless call in extension activation #158

jeffmaury opened this issue Jun 20, 2023 · 5 comments · Fixed by #169

Comments

@jeffmaury
Copy link
Collaborator

Seems to be this function call is useless.

extensionApi.configuration.getConfiguration();

@gbraad
Copy link
Contributor

gbraad commented Jun 21, 2023

I believe this call is to make sure the extension populates the fields in the preferences, as we do not store them as part of the Podman Desktop preferences.

/cc: @evidolob

@jeffmaury
Copy link
Collaborator Author

Adding @benoitf

@benoitf
Copy link
Contributor

benoitf commented Jun 21, 2023

I'm not fully sure of what it does as preferences should always be there ?

@gbraad
Copy link
Contributor

gbraad commented Jun 21, 2023

as preferences should always be there ?

Preferences will only be there when we populate with the values from our API/backend. Values we get from the UI will immediately be pushed back to our backend; the SPOT is not within PD.

@evidolob
Copy link
Contributor

evidolob commented Aug 9, 2023

I think that was a mistake, we don't need that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants