You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The build succeeds, and chalk is fully functional. In particular, a chalk insert should insert a chalk mark that contains the git commit ref from which chalk was built, like:
Example
cd
to the extracted locationnimble build
This is relevant for packaging chalk - see https://github.com/crashappsec/internal_tickets/issues/138.
Expected behavior
The build succeeds, and chalk is fully functional. In particular, a
chalk insert
should insert a chalk mark that contains the git commit ref from which chalk was built, like:Observed behavior
The build succeeds, but then a
chalk insert
inserts a chalk mark with a badCOMMIT_ID
value, which contains an error message instead of a commit ref.The
chalk version
output has the same issue:Diagnosis
We have some
staticExec
that silently use the command's output even when the command indicates an error:chalk/src/chalk_common.nim
Lines 362 to 364 in cf9ebf8
chalk/src/attestation.nim
Lines 13 to 14 in cf9ebf8
These should use
gorgeEx
, or some wrapper around that.The text was updated successfully, but these errors were encountered: