add amplitude parameter to sonify.pitch_contour #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rabitt ! I am traveling until Monday, so if someone else with push access wants to CR before then feel free. Looks like for now at least the test needs to be updated to fix Travis. |
ejhumphrey
previously requested changes
Nov 2, 2017
tests/test_sonify.py
Outdated
|
|
||
| # Test with explicit amplitude | ||
| x = mir_eval.sonify.pitch_contour(times, freqs, fs, length=fs * 7, | ||
| amplitude=amps) |
There was a problem hiding this comment.
does this work? isn't the kwarg named amplitudes (plural)?
rabitt
force-pushed
the
sonify-pitch-contour-amplitude
branch
from
3c11083 to
b3e470e
Compare
rabitt
force-pushed
the
sonify-pitch-contour-amplitude
branch
from
b3e470e to
3498505
Compare
|
My guess is that this is due to a breaking Matplotlib release. I will create a separate issue. |
…ify-pitch-contour-amplitude
|
@ejhumphrey @craffel I think this is good to go? |
craffel
requested changes
Nov 9, 2017
| else: | ||
| # build an amplitude interpolator | ||
| a_interp = interp1d( | ||
| times * fs, amplitudes, kind=kind, |
There was a problem hiding this comment.
Can you change the docstring for kind so that it reads
Interpolation mode for the frequency and amplitude values.
craffel
approved these changes
Nov 10, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional
amplitudeparameter tosonify.pitch_contourthat applies an amplitude envelope to the pitch contour.