Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forced integer division in beat pscore #236

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

bmcfee
Copy link
Collaborator

@bmcfee bmcfee commented Feb 12, 2017

This should fix #235 , or at least the one problem that was hitting me over in JAMS land.

@bmcfee bmcfee added the bug label Feb 12, 2017
@bmcfee bmcfee added this to the 0.5 milestone Feb 12, 2017
@bmcfee bmcfee requested a review from craffel February 12, 2017 14:20
@craffel
Copy link
Collaborator

craffel commented Feb 12, 2017

Looks good, I think we can just merge despite the failing tests addressed in other issues, yeah?

@bmcfee
Copy link
Collaborator Author

bmcfee commented Feb 13, 2017

Looks good, I think we can just merge despite the failing tests addressed in other issues, yeah?

I think this also applies to #234, if you want to take a quick skim on the error log.

@bmcfee bmcfee merged commit a9135c2 into mir-evaluation:master Feb 13, 2017
@bmcfee bmcfee mentioned this pull request Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

float-valued indexing will break everything on numpy >= 1.12
2 participants