TF Prefix Bug #876
Merged
TF Prefix Bug #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `tf_prefix` parameter is stored in unused variable `tf_prefix_path`. Please fix this.
|
Ah, this is because in ROS 1, we were searching for the parameter key before loading it: robot_localization/src/ros_filter.cpp Line 848 in 7bebbed But ROS 2 has no support for that. Technically, |
ayrton04
approved these changes
Apr 16, 2024
|
Thanks for the PR! |
ayrton04
pushed a commit
that referenced
this pull request
Apr 16, 2024
The value of `tf_prefix` parameter is stored in unused variable `tf_prefix_path`. Please fix this.
ayrton04
pushed a commit
that referenced
this pull request
Apr 16, 2024
The value of `tf_prefix` parameter is stored in unused variable `tf_prefix_path`. Please fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
tf_prefixparameter is stored in unused variabletf_prefix_path. Please fix this.