From ec7e0313813d5e19fd3e51d490584eabc60b58d3 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 3 Jun 2024 22:28:29 -0700 Subject: [PATCH 1/2] test passive-reviews --- .github/workflows/cpp-lint-package.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 99d1c81..33867a2 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -7,6 +7,7 @@ on: description: 'which branch to test' default: 'main' required: true + pull_request: jobs: cpp-linter: @@ -16,7 +17,7 @@ jobs: matrix: clang-version: ['7', '8', '9','10', '11', '12', '13', '14', '15', '16', '17'] repo: ['cpp-linter/cpp-linter'] - branch: ['${{ inputs.branch }}'] + branch: ['passive-reviews'] # ['${{ inputs.branch }}'] fail-fast: false steps: @@ -66,6 +67,8 @@ jobs: --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} + --passive-reviews=true + --format-review=true - name: Fail fast?! if: steps.linter.outputs.checks-failed > 0 From b0791ce6f53d182732d49c3190ed40413321e9d3 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Mon, 3 Jun 2024 22:32:58 -0700 Subject: [PATCH 2/2] only use PR review for clang-format-14 --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 33867a2..57baa2b 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -68,7 +68,7 @@ jobs: --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} --passive-reviews=true - --format-review=true + --format-review=${{ matrix.clang-version == '15' }} - name: Fail fast?! if: steps.linter.outputs.checks-failed > 0