-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify which tool(s) to install #27
Comments
It would be nice to support users in installing specific tools. For cpp-linter-action, I think it's OK to provide both tools (including clang-format and clang-tidy) if the user only uses one of them. It will add a small amount of download time, but the logic is more simple than adding more |
clang-format or clang-tidy is installed with |
This an advanced example. The defaults should suffice for our needs. What if someone wants to use this pkg to get the statically linked clang-query binary? |
Your implementation proposal like great, users could use this way to install clang-query binary. |
I saw that the user from the upstream repo of cpp-linter/clang-tools-static-binaries was asking to have I don't have much of an impression of how other tools implement similar functionality, and so far I prefer option 1 (option 2 is also not bad) |
It would be nice to let the user choose which tool(s) to install. This way we could only install clang-tidy in the cpp-linter-action (composite form) if
inputs.tidy-checks != '-*
. Or we could avoid installing clang-format if theinputs.style != ''
.Since the releases of binary builds also include the clang-query tool, users could specify that as well.
Implementation
Option 1
Option 2
I haven't decided which way to support. Maybe there's a way to support either or both options.
I would expect the current default ( clang-tidy + clang-format) to be overridden when
-t
is specified.The text was updated successfully, but these errors were encountered: