Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.104] Classic ETH-flow does not work as it should be #5483

Open
elena-zh opened this issue Mar 6, 2025 · 0 comments
Open

[1.104] Classic ETH-flow does not work as it should be #5483

elena-zh opened this issue Mar 6, 2025 · 0 comments
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link
Contributor

elena-zh commented Mar 6, 2025

Related to the refactoring done in #5443

1 Pick ETH token as a sell token
2. Select any other token in the buy field (but WETH)
3. Specify ETH sell amount > WETH balance in the wallet
4. Expand classic eth-flow modal and press on the Wrap my ETH and swap buttonImage
5. Proceed with wrapping and approving (if needed)
6. Press on the Swap button and place the orderImage

AR: regular ETH-flow order is placed

Image

And this makes impossible to place ETH-flow order with a SC wallet

Image

ER: offchain order with selling WETH token should be placed

@elena-zh elena-zh added Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

No branches or pull requests

1 participant