Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error handling for quotes #4424

Closed
anxolin opened this issue May 14, 2024 · 2 comments
Closed

Bad error handling for quotes #4424

anxolin opened this issue May 14, 2024 · 2 comments
Labels
Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt

Comments

@anxolin
Copy link
Contributor

anxolin commented May 14, 2024

Description

I can see we have an issue with our quoting 😅
We do 2 quotes, FAST and VERIFIED.
FAST returns:

{
  "errorType": "QuoteNotVerified",
  "description": "No quote for this trade could be verified to be accurate. Orders for this trade will likely not be executed."
}

Which I don't understand, as fast should not need verified quotes.
VERIFIED work, which is odd if fast fails!

{
  "sellToken": "0xfff9976782d46cc05630d1f6ebab18b2324d6b14",
  "buyToken": "0xbe72e441bf55620febc26715db68d3494213d8cb",
  "from": "0x54400BF44b7c5B3a8b70c958786ADFD74f1219Db",
  "receiver": "0x54400BF44b7c5B3a8b70c958786ADFD74f1219Db",
  "appData": "{\"appCode\":\"CoW Swap-SafeApp\",\"environment\":\"pr\",\"metadata\":{\"orderClass\":{\"orderClass\":\"market\"},\"quote\":{\"slippageBips\":50}},\"version\":\"1.1.0\"}",
  "appDataHash": "0x8d14d6e013f23bc66da0eb5714bbc0ad409f0c0cdc7e94d2986a8925a6ac90c3",
  "partiallyFillable": false,
  "priceQuality": "verified",
  "validFor": 1800,
  "kind": "sell",
  "sellAmountBeforeFee": "1000000000000000000"
}

The real issue to fix

But the biggest issue I see is, in the frontend, we handle badly this error and we don't let the user continue. So this is very problematic.

How to Reproduce

  • Make the FAST quote to fail, and the VERIFIED to succeed.
  • The button is disabled
@anxolin anxolin added Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt labels May 14, 2024
@elena-zh
Copy link
Contributor

Hey @anxolin , is this issue still relevant?

@anxolin
Copy link
Contributor Author

anxolin commented Feb 21, 2025

I think we can close

@anxolin anxolin closed this as completed Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical Severity indicator for defects. ndicates complete shut-down of the process. Nothing can proceed furt
Projects
None yet
Development

No branches or pull requests

2 participants