Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Limit orders] Modify order (cancel+create) #425

Closed
6 tasks
anxolin opened this issue Apr 20, 2022 · 3 comments · Fixed by #4015 or #3845
Closed
6 tasks

[Limit orders] Modify order (cancel+create) #425

anxolin opened this issue Apr 20, 2022 · 3 comments · Fixed by #4015 or #3845
Assignees

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 20, 2022

Description

Allow users to replace existing orders

Additional resources

This feature involves allowing users to, in a single operation, cancel existing orders and replace it with a new one.

It also allows users to "replay" existing orders by pre-filing the UI with data for a previous order.

Feature breakdown
It includes:

  • Adding to recent activity [1]
  • Recreate order (Canceled / Filled) UI [5]
  • Replace order (Pending) [10]
  • Sign the order: Add meta-info to the order so backend ensures that only one of the orders are executed [2]
  • Replacing/Replace logic for old pending: only for new [5]

Good to have:

  • ???

Original issue gnosis/cowswap#2467 by @alfetopito

@anxolin anxolin added the Epic label Apr 20, 2022
@anxolin anxolin added WebSquad and removed Epic labels Aug 23, 2022
@elena-zh elena-zh removed the WebSquad label Feb 1, 2023
@alfetopito
Copy link
Collaborator

FYI, backend support for cancel+place is available for almost 2y cowprotocol/services#239

Given that it has been sitting for so long without integration, I believe it's outdated, specially in regards to appData field usage.

By the time it was implemented, there was no appData schema definition.
This field however stores important information for Fronted, Backend and Analytics. Replacing the original order's appData with cancellation specific format can cause all sorts of issues making it unfortunately not worth it in the current state.

@alfetopito
Copy link
Collaborator

Backend work to update the endpoint while keeping up with current appData expectations tracked on cowprotocol/services#2365

@anxolin anxolin changed the title Replace orders [Limit orders] Modify order (cancel+create) Feb 8, 2024
@alfetopito
Copy link
Collaborator

As part of this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants