Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LENS-1642): support for SAP specific user-agent header #128

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

jgwatkincoveo
Copy link
Contributor

@jgwatkincoveo jgwatkincoveo commented Mar 27, 2024

LENS-1642

This PR will allow the value in the user agent header field to be set to the SAP Commerce version of the connector. This can only be done via the stream services as the CoSAP Connector can only use these 2 services. (PushSource is out of scope for this feature request)

@jgwatkincoveo jgwatkincoveo requested a review from a team as a code owner March 27, 2024 10:58
@jgwatkincoveo jgwatkincoveo requested review from olamothe, y-lakhdar, fbeaudoincoveo, sallainCoveo and samisayegh and removed request for a team March 27, 2024 10:58
@jgwatkincoveo jgwatkincoveo changed the title feat(LENS-1642) Support for SAP specific user-agent header feat(LENS-1642): Support for SAP specific user-agent header Mar 27, 2024
@jgwatkincoveo jgwatkincoveo changed the title feat(LENS-1642): Support for SAP specific user-agent header feat(LENS-1642): support for SAP specific user-agent header Mar 27, 2024
Copy link

@samisayegh samisayegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could discuss the enum, but otherwise looks good ✅

@jgwatkincoveo jgwatkincoveo merged commit 279a26b into main Apr 5, 2024
5 checks passed
@jgwatkincoveo jgwatkincoveo deleted the feature/LENS-1642 branch April 5, 2024 09:08
This was referenced Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants