Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pangolin --all-versions pollutes STDOUT with ANSI chars #421

Closed
dpark01 opened this issue Apr 8, 2022 · 1 comment
Closed

pangolin --all-versions pollutes STDOUT with ANSI chars #421

dpark01 opened this issue Apr 8, 2022 · 1 comment

Comments

@dpark01
Copy link

dpark01 commented Apr 8, 2022

It seems that since the switch to pangolin v4, pangolin --all-versions now emits something like the following (as viewed via less):

[32m****;Pangolin running in usher mode.;****ESC[0m;pangolin: 4.0.3;pangolin-data: 1.2.133;constellations: v0.1.4

Whereas previously in pangolin v3, it was strictly a machine-parsable list of version numbers. Given that pangolin --all-versions is frequently parsed by wrapper scripts and pipelines and conveyed downstream in public health reporting, it would seem to me that both the ANSI coloring control characters, as well as the **** and "running in usher mode" message should perhaps be shuffled to STDERR or suppressed or otherwise removed from the STDOUT stream, which should be kept clean for machine parsing.

To be honest, "Pangolin running in XXX mode" is kind of an untrue statement for --all-versions anyway, since it isn't really running at all. Maybe removing this whole colored block is the right way to go?

@dpark01
Copy link
Author

dpark01 commented Apr 8, 2022

oops, dupe of #420

@dpark01 dpark01 closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant