Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MsgSetWithdrawAddress #71

Closed
Tracked by #14007
vietnamese-chowder opened this issue Sep 30, 2022 · 2 comments
Closed
Tracked by #14007

Support for MsgSetWithdrawAddress #71

vietnamese-chowder opened this issue Sep 30, 2022 · 2 comments

Comments

@vietnamese-chowder
Copy link

I'm trying to sign a MsgSetWithdrawAddress, and correct me if I'm wrong, but it seems it's not supported currently. During signing I see cosmos-sdk/MsgSetWithdrawAddress as the message type as opposed to "Withdraw Address" or something like that and the withdraw address field name is also not "prettified" as with MsgSend or MsgDelegate, and sending with it throws a signature error. Can you please support this message type?

This is the message I'm passing to sign:

{
  "account_number": "8",
  "chain_id": "testing",
  "fee": {
    "amount": [
      {
        "amount": "5000",
        "denom": "uatom"
      }
    ],
    "gas": "200000"
  },
  "memo": "",
  "msgs": [
    {
      "type": "cosmos-sdk/MsgSetWithdrawAddress",
      "value": {
        "delegator_address": "cosmos1hr9x0sjvel6z3vt9qny8sdd5gnnlgk0p69d6cv",
        "withdraw_address": "cosmos12d64j98tjjpqkx70r08aspc4nvntqp2w6wr2de"
      }
    },
    {
      "type": "cosmos-sdk/MsgWithdrawDelegationReward",
      "value": {
        "delegator_address": "cosmos1hr9x0sjvel6z3vt9qny8sdd5gnnlgk0p69d6cv",
        "validator_address": "cosmosvaloper13dr26wdygna3s8fdl5tlc45m2le2ydyddxzj49"
      }
    }
  ],
  "sequence": "7"
}
@vietnamese-chowder
Copy link
Author

Not sure if necessary, but here is the documentation on this type of message: https://docs.cosmos.network/v0.44/core/proto-docs.html#cosmos.distribution.v1beta1.MsgSetWithdrawAddress

@ftheirs ftheirs mentioned this issue Jan 2, 2023
Merged
@ftheirs
Copy link
Contributor

ftheirs commented Jan 2, 2023

Messages were prettified and tests were added to the app to check these improvements! It will be available since next release! PR: #77
Thanks for reporting this issue!

PS: the transaction can be signed with previous versions of the app 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants